Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JMX support for native s3 filesystem #23304

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Add JMX support for native s3 filesystem #23304

merged 1 commit into from
Sep 13, 2024

Conversation

ljw9111
Copy link
Contributor

@ljw9111 ljw9111 commented Sep 5, 2024

Description

This PR is implementation for the issue in #23177

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(O) Release notes are required, with the following suggested text:

# Section
* Added JMX monitoring support for native s3 filesystem

@cla-bot cla-bot bot added the cla-signed label Sep 5, 2024
@github-actions github-actions bot added the iceberg Iceberg connector label Sep 6, 2024
@ljw9111
Copy link
Contributor Author

ljw9111 commented Sep 6, 2024

@electrum Thank you for your review! I just made revision reflecting your comments. Could you take a look when you get chance?

@ljw9111 ljw9111 self-assigned this Sep 7, 2024
@ljw9111 ljw9111 force-pushed the jmx-native-s3 branch 2 times, most recently from 48b3dc1 to a0f353d Compare September 9, 2024 15:18
@sopel39
Copy link
Member

sopel39 commented Sep 13, 2024

lgtm. @electrum @pettyjamesm do you want to look?

@pettyjamesm
Copy link
Member

LGTM, was waiting to see if @electrum was going to come back and re-review but with your approval I'm good to merge this. One question is which section this release notes belongs to, but we can figure that out during the release notes process.

Thanks, @ljw9111!

@pettyjamesm pettyjamesm merged commit 4c4edc4 into trinodb:master Sep 13, 2024
59 checks passed
@github-actions github-actions bot added this to the 458 milestone Sep 13, 2024
@wendigo
Copy link
Contributor

wendigo commented Sep 13, 2024

ouch, logical merge conflict @pettyjamesm

@wendigo
Copy link
Contributor

wendigo commented Sep 13, 2024

#23409

@mosabua mosabua mentioned this pull request Sep 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sopel39 sopel39 sopel39 approved these changes

@pettyjamesm pettyjamesm pettyjamesm approved these changes

@electrum electrum Awaiting requested review from electrum

Assignees

@ljw9111 ljw9111

Labels
cla-signed iceberg Iceberg connector
Milestone
458
Development

Successfully merging this pull request may close these issues.
5 participants
@ljw9111 @sopel39 @pettyjamesm @wendigo @electrum